all: add user agents and improve build info log #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
added
type: enhancement
joshuasing
requested review from
a team,
marcopeereboom and
ClaytonNorthey92
as code owners
github-actions
bot
added
area: bfg
joshuasing
changed the title
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
ClaytonNorthey92
requested changes
Aug 15, 2024
There was a problem hiding this comment.
hey @joshuasing I have a very small request change to a test; it is almost a nitpick but I think it would help determine which test fails if one does.
additionally, and this is completely optional but would give me peace of mind 😌 , I would love a test that sends a specific UserAgent to bfg, and ensured that bfg received the useragent correctly (i.e. there is no issue reading that value from where it should be)
ClaytonNorthey92
approved these changes
Aug 20, 2024
marcopeereboom
requested changes
Aug 21, 2024
marcopeereboom
approved these changes
Aug 21, 2024
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
User-Agentheaders and aUserAgentto the secp256k1 authenticator.This allows our HTTP connections to be identifiable, and provides some basic information about the client.
Changes
versionpackage.User-Agentheader to the popm->bfg connection.UserAgentto the secp256k1 authenticator.version.PreReleasevariable at link-time for releases.BuildInfo()function toversionpackage that includes basic information about the environment that is useful for debugging.